Combining ability was studied for identification of potential cultivars and hybrids in upland cotton (Gossypium hirsutum L.) in a 6×6 set of diallel crosses among six genotypes of cotton, i.e., VH-232, CRS-2007, SB-149, GR-156, FH-207, and MARVI carried out on fiber length, fiber fineness, fiber elongation, fiber strength, ginning out tern (GOT) and seed cotton yield. Analysis of variance revealed highly significant (p ≤ 0.01) differences among the genotypes for all traits. Combining ability studies showed that the mean squares, due to general combining ability (GCA), specific combining ability (SCA) and reciprocal effects were highly significant in F1 generation. Genetic components, due to GCA and SCA, revealed that traits, such as, fiber length, strength and fineness, showed high proportion of additive type of gene action in F1 generation because of greater GCA variances were greater than SCA variance. GR-156 was the best combiner for lint percentage and fiber length. FH-207 was the best combiner for fiber fineness. FH-207, MARVI and SB-149 were the best general combiners for fiber character and were suggested to be used in future breeding programme to improve fiber quality traits. CRS-2007 × GR-156, CRS-2007 × MARVI, SB-149 × MARVI and VH-232 × SB-149 had higher specific combining ability and reciprocal effects and they can be used for future breeding programme to improve fiber quality.