In a study conducted at Agricultural Research Institute, Tandojam, Pakistan, during the year 2008-2009 a line x tester analysis was made to identify the superior general and specific combining parents for agro-economic traits in upland cotton. Five lines/females (Sadori, Chandi-95, Bt, CRIS-9 and NIAB-78) and three testers/males (Sindh-1, Shahbaz and CRIS-134) were crossed to develop 15 F1 hybrids. These genotypes were evaluated alongwith parents in RCBD with three replications. The general combining ability (GCA) and specific combining ability (SCA) mean squares for sympodial branches, bolls per plant, seed cotton yield and lint percentage were significant except boll weight which was non-significant. The GCA variances were higher than SCA indicating greater importance of additive against non-additive genes, especially dominant ones in advocating these traits. Parents CRIS-9 and NIAB-78 among lines and CRIS-134 from testers were found as good general combiners for most of the traits. Hence these parents proved worth to be used in hybridization and selection programme for extracting desirable plants from segregating population. F1 hybrids Chandi-95 x Shahbaz, Sadori x Sindh-1, NIAB-78 x CRIS- 134, NIAB-78 x Shahbaz and CRIS-9 x Sindh-1, by and large, exhibited their superiority for all traits studied and were noted as the best specific combiners. Therefore, these hybrids may be preferred to improve several traits simultaneously by selection or may be used for hybrid cotton crop development.