Three widely adapted cotton (Gossypium hirsutum L.) lines viz VI-I-148, CIM-496, F11- 901 were used as female to make 18 crosses in line x tester fashion with six cotton genotypes, i.e., FH-115, FH-900, FVH-53, B-1580, NIAB-884 and AET-5 (testers) of different ecological origin. The F 1 generation was studied for variance and effects ofgeneral and specific combining ability for traits of economic importance viz, seed cotton yield per plant, bolls per plant, boll weight, ginning out-turn., and fibre/staple length. Inheritance study revealed predominantly non-additive genetic effects for seed cotton yield per plant, bolls per plant, boll weight and ginning out-turn, both additive and -non- additive gene action was estimated for staple length. VII-148 proved best lire, and FH-11Sand FH-900 good tester, respectively, in general combination for yield and bolls per plant. The line CIM-496 was good combiner for boll weight and staple length. The cross VH-148 x H/- 900 and FH-901 x N14 B-884 exhibited high specific combining ability for yield per plant and bolls per plant.