A 6 x 6 diallel cross experiment on rice was conducted in saline sodic soil at Soil Salinity Research Institute, Pindi Bhattian, Punjab, Pakistan during 2013-14. The parents F1 and F2 generations were grown and data were collected on eight agro-physiological traits for each generation. Six rice genothypes viz. Basmati-370, Super Basmati, Shaheen Basmati, Basmati PB-95, NIAB IRRI-9 and Basmati-385 were tested in the study. The included traits were, days to maturity, plant height, panicle fertility, tillers per plant, panicle length, shoot dry weight, paddy yield per plant and 1000-grain weight. Three chemicals i.e. Na, K and Ca were also determined from both generations. The data were processed for combining ability analysis in both generations. The results revealed that additive effects were preponderance for panicle length, plant height and number of tillers per plant in both generations. For the traits like paddy yield, shoot dry weight, days to maturity and panicle fertility non-additive effects were more prominent. This study further indicated that in both generations non-additive effects were preponderance for sodium content, calcium content and potassium sodium ratio of shoot. The crosses of Basmati 385 x NIAB IRRI-9, Shaheen Basmati x Basmati 385 and Shaheen Basmati x Basmati 370 were better for traits like paddy yeild, salt tolerance and early maturity. The study also revealed that Shaheen Basmati proved to be the best combiner for all traits followed by Basmati PB-95. Moreover, cross combinations of Shaheen Basmati with different genotypes gave SCA effects for most of the traits.